Delete .lock file after shutting down control node #2651
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Maverobot,
bijoua29,
bmagyar,
homalozoa,
livanov93,
moriarty and
saikishor
christophfroehlich
previously approved these changes
Oct 9, 2025
christophfroehlich
changed the title
saikishor
reviewed
Oct 10, 2025
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2651 +/- ##
==========================================
- Coverage 89.37% 89.35% -0.02%
==========================================
Files 151 151
Lines 17037 17043 +6
Branches 1420 1421 +1
==========================================
+ Hits 15227 15229 +2
- Misses 1256 1258 +2
- Partials 554 556 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
approved these changes
Oct 15, 2025
|
Closing in the interest of #2677 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2330 by explicitly deleting the lock file after spawning a controller. A log message is also added.